Alan Turing Tribute Page - Looking for Feedback

Alan Turing Tribute Page - Looking for Feedback
0

#1

Hi All, like many of you are or were I’m a newbie making my way through the freeCodeCamp tutorials when I can and I have just finished up my Tribute Page project.

I’m looking for any and all feedback that I can apply to this project / future projects going forth so I can break the bad habits early!

Please feel free to view it here: http://codepen.io/IrTaki/pen/rWNBBj/

Things I’m going to implement shortly:

  1. A different font style for the text.
  2. Look to add a bit of colour to the page.

Thank you in advance for any advice and feedback you can provide :slight_smile:


#2

Hi @IrTaki,

Is better not use the style attribute:

<div style="margin-left: auto; margin-right: auto; width: 960px">

Because, you have multiple styles sources (That’s make the page more difficult to review.):

  • The CSS tab
  • Every element on the html with the style attribute

This doesn’t looks like a heading (and there is a h3/h4 mismatch)

 <h3 style="margin-left: 128px; text-align: left; margin-right: 128px">If you have time, you should read more about this incredible human being on his <a href="https://en.wikipedia.org/wiki/Alan_Turing" target="_blank">Wikipedia entry.</a></h4>

Cheers and happy coding :slight_smile: