Hi everyone,
Just completed my first project with FreeCodeCamp, the infamous Tribute Page.
Let me know what you think
(https://codepen.io/lauric-h/pen/abOrewr)
Thanks !
Hi everyone,
Just completed my first project with FreeCodeCamp, the infamous Tribute Page.
Let me know what you think
(https://codepen.io/lauric-h/pen/abOrewr)
Thanks !
Hi @Lauric_Olrik! I really like your design there.
Have you run the tests yet? Just in case, they are located here:
I think they can point you first to what to improve. Once these are done, I’m happy to help out more!
Hi and thanks for your reply
Yes I ran the test (10/10). Should I do something more ?
Ohhh, I’m sorry, I didn’t notice I had the wrong test suite selected.
Here are my suggestions:
<footer>
:
<main>
;<header>
;<figure>
;<section>
;<figcaption>
tag;<i>
with <em>
;Other than that:
<p>
tag for the subtitle instead of (as many people do), another header;@sylwiavargas
Thanks a lot for this valuable feedback, I’ll make the changes !
I tend to see div as a do-it-all thing adding id and class, I will definitely remember to use the correct HTML semantics instead