Build A Java Script Calculator: Feedback

<%= @topic_view.topic.title %>
<%= @topic_view.topic.average_rating %> <%= @topic_view.topic.posts.count { |p| !!p.custom_fields['rating'] } %>

Hey Everyone,

I finished the calculator project with all test passing but was wondering what my fellow developers think about it? Any feedback very much appreciated.

Calculator app

I’ve looked it over and it is quite good. There are two problems I noticed though:

  1. Test 13 doesn’t pass ( If 2 or more operators are entered consecutively, the operation performed should be the last operator entered(excluding the negative (-) sign))
  2. You don’t handle recurring numbers correctly as the result of 1/3 multiplied by 3 (two separate equations) equals 0.9 recurring, not one.

I hope this helps.

1 Like

@paladinvaan2018

Thanks ten trillion! That really did help. I thought I had all tests passing but it turns out I tried to separate the minus functionality into the +/- button which failed the test. All tests should be passing now. As for the recurring numbers they should now round off into their appropriate values.