Chatrapati Shivaji Maharaj. please give your feedback

It looks nice, except for the main heading popping out of the box at the top. Try adjusting the placement for that.

Also, I recommend reviewing your use of heading elements. For example, your main heading ā€œChatrapati.Shivaji Bhosale. (Maharaj)ā€ should probably be an < h1 >. Headings can affect what information shows up in search engines, so make sure youā€™re giving priority to the headings that will help people find your page in a search.

From w3schools.com: "Search engines use the headings to index the structure and content of your web pages.

Users skim your pages by its headings. It is important to use headings to show the document structure.

< h1 > headings should be used for main headings, followed by < h2 > headings, then the less important < h3 >, and so on.

Note: Use HTML headings for headings only. Donā€™t use headings to make text BIG or bold."

I hope this information helps! :sunny:

1 Like

thank you for viewing and also for giving adviseā€¦ its motivation for me to keep going. i will defenitely improve where iā€™m laking :pray:

Your page looks okay @Dipak. Some things to revisit;

  • Keep the test script when forking the pen (<script src="https://cdn.freecodecamp.org/testable-projects-fcc/v1/bundle.js"></script>).
    • The test script should be included, with all tests passing, when you submit your projects.
    • Your page passes 1/10 user stories. Click the red button to see which test(s) are failing and text to help you correct the issue.
  • Run your HTML code through the W3C validator.
    • There are HTML coding errors you should be aware of and address.
    • Since copy/paste from codepen you can ignore the first warning and first two errors.
  • Donā€™t use the <br> element to force line breaks or spacing. Thatā€™s what CSS is for.
  • Userā€™s are not seeing your page the way you want them to. Most wonā€™t have ā€˜Roboto Slabā€™ loaded on their computer and you neither link to it (head element in HTML) or import it (CSS).
    • Also review how to call a font that has spaces in the name and review how to have a fallback font.
1 Like

i will try my best to redesign the page with less errors. thank you very much sir for looking my code and giving me advise :pray:ā€¦ i got inspiration from your comment to try strengthen my skills. thank you :smiley:

I am so sorry. I didnā€™t realize this was three years old. I donā€™t know what caused it to pop to the top.
I wouldnā€™t have responded if I knew it was that old.

no sirā€¦ i wasnā€™t doing anything in web-developement. i just learnt, did small projects and left and forgotten what i learned. your comment give me motivation to polish my knowledge ā€¦ so thank you

1 Like