FCC Calculator - Wow it works! Hmm... I think so... better test it :)

Code Feedback
1

Finally I managed to finish calculator. I was stuck for a long time because of the summer break :slight_smile: What do you think? Are there any critical mistakes? Do You have any idea for improving this app (“need to do” or “nice to do”)?


Thanks in advance for constructive feedback :slight_smile:

2

The app seems to work as it should. I personally found the the text shadows made some of the text difficult to read, but did not influence the functionality of the app.

Often the operation buttons are colored differently than the numeric buttons, but again, this does not really affect the functionality.

I think that you got the functionality down, which i think is the underlying point of this project.

Nice job!

3

I have turned off shadows, You are right, it is better now. Thanks

4

If number is longer than 15 digits it gets out of screen.

You should add

  -moz-user-select: none;
  -webkit-user-select: none;
  -ms-user-select: none;

and

cursor: default;

to your body in CSS so the cursor doesn’t change and the numbers on buttons won’t get highlighted.

calc.png462Ă—556 16.9 KB

5

@jenovs Good point, I have to fix that. Thank You

6

@jenovs Display size is fixed. I have to use textarea instead of div to modify size dynamically :slight_smile: If there is no more bugs I will start coding pomodoro clock. :wine_glass:

7

Something is wrong :

img.png446Ă—508 13 KB

8

@jenovs thanks. What browser are You using? I can not reproduce this bug on chrom…

I’ve added width 100% to textarea… hope this solves the problem?

9

Now it’s ok. I’m on Ubuntu and I had this bug both in Chrome and FF.

10

Thanks for help with debugging. Now it is time to :tomato: project… and breakfest :relaxed: