FCC: Product Landing Page - feedback needed

Code Feedback
1

Hi, I finally finished my Product Landing Page challenge and I would like some feedback for my work. I would say I worked hard on this project as I didn’t want to rush for the certificate and do the bare minimum. Although I used it in my project, I am kind of new to Javascript. Please tell me anything that you think I could have done better both design and script-wise. Thank you!
https://codepen.io/VortexFeri/full/Baoezpm

P.S.: I think I must mention that I used VScode to make this project and I uploaded the images on a imgur account.

2 Likes
2

Just one word… Beautiful :slightly_smiling_face: :slightly_smiling_face:

3

awesome👍🏻

i might say it beyond my expectation.
the work on css is something far to learns for a begginer like me.:upside_down_face:

4

Absolutely lovely work. Very impressive!

A few tips I recently learned myself, you can use W3’s validator for HTML, and the inbuilt CSS analyzer in codepen (via clicking the downward facing arrow and then analyze) in order to screen your code for any errors or whatnot.

https://validator.w3.org/#validate_by_input

I’ve found it to be extremely helpful for finding any misplaced elements or syntax errors personally.

1 Like
5

Page looks good @fericarnu. Some things to revisit;

  • Keep the test script when forking the pen (<script src="https://cdn.freecodecamp.org/testable-projects-fcc/v1/bundle.js"></script>).
    • The test script should be included, with all tests passing, when you submit your projects.
  • Don’t use <br> to force line breaks. Use CSS.
  • As previously mentioned, run your HTML code through the W3C validator.
    • Since copy/paste from codepen you can ignore the first warning and first two errors.
    • There are coding errors you should address.
1 Like