FCC project feedback

Code Feedback
1

Hi can you review my tribute page and leave feedback that would be great thanks.
The link to my page in here https://stuartbiggs.github.io/Tribute-Page/

2

Hey Stuart,

great work,
simple and easy to read.

Some ideas:

  • remove unused code, e.g. #timeline in the CSS file
  • you have some lines in your CSS that start with //
  • you use <strong> in your HTML, that’s for saying that something is important. I don’t think you want to make these words important, only bold, therefore this should go into CSS
  • there’s a duplicate entry in the last line

Keep up the good work.

1 Like
3

Hi @stuartbiggs, your page looks good but some things you may want to revisit;

  • Keep the test script when forking the pen (<script src="https://cdn.freecodecamp.org/testable-projects-fcc/v1/bundle.js"></script>). Your page passes 7/10 user stories.
  • Make your page responsive. (Users shouldn’t have to scroll left & right to see your entire page)
1 Like
4

For a first time project, this is really good.

You have a horizontal scroll. Try not to have one whenever you make a website.
Maybe get a font that matches what you are making.

try and smooth some things out with the border-radius css command.

Great job and keep up the great work.
:smiley:

1 Like