Feedback on curriculum survey form

<%= @topic_view.topic.title %>
<%= @topic_view.topic.average_rating %> <%= @topic_view.topic.posts.count { |p| !!p.custom_fields['rating'] } %>

Hey guys,

i always want to improve so i would love to hear some feedback and advice on this project from you.

survey form for curriculum

Every feedback is appreciated!

Hi @d0sch1, your form looks good. A couple of things you may want to revisit;

  • codepen only expects the code you’d put within the <body> </body> tags in HTML. (No need to include the body tags). For anything you want to add to the <head> click on the ‘Settings’ button and add it into the ‘Stuff for <head>’ box.
  • it’s a nit but black and white are not good color choices for viewing, they’re more for print media. For a webpage better colors are #333 and #f9f9f9.
  • codepen provides validators for HTML, CSS and JS. Click on the down arrow in the upper right of each section and then click on the respective ‘Analyze’ link.
    • You have some empty blocks in CSS and a small typo in HTML. (Don’t worry abou the cols and rows attributes msg that codepen tells you about. The better way to do it is with CSS.
  • Another typo in the ‘are you doing enough section’. The available responses are the same.

Hey @Roma so glad you explained the <head> part I did not know that.

I am going to tackle the optimization tomorrow thanks for the advice!

1 Like