Feedback on Front End Development Project - Tribute Page

Feedback on Front End Development Project - Tribute Page
0

#1

Hi All,

First post here but my name is Lee from London, currently working within a ICT Business team and spend around 2 hours a day learning to code in my free time.

Been going through the freeCodeCamp content and just completed the tribute page task and would like some feedback if any of you have some spare time to take a look?

all feedback welcome negative/positive.

Lee’s Codepen page

thanks in advance.

Lee


#2

Hi @Leeamurphy20,

html inspector:

  • ‘active’ is not a valid attribute of the <li> element ( you need an “equal” sign ):
<li class "active"><a href="#">Home</a></li>


  • Error, line 25 unclosed <ul> element:
<ul style="font-size: 18px"
    <li><strong>Oct 28 1955</strong>
    ....


HTML inspector:

  • The <br> element cannot be a child of the <ul> element.
<ul style="font-size: 18px"  <!-- no starting tag --> 
 
...

 <li><strong> Feb 4 2009</strong> - TED 2009 held in Long Beach, CA</li>
    <ul></br></br></br> <!-- no ending tag -->

MDN documentation:
https://developer.mozilla.org/en-US/docs/Web/HTML/Element/ul

Permitted content
zero or more <li> elements, eventually mixed with <ol> and <ul> elements.


Cheers and happy coding :slight_smile: