Feedback on Portfolio, Quotes Machine, Weather, and Wikipedia Viewer

Feedback on Portfolio, Quotes Machine, Weather, and Wikipedia Viewer
0

#1

Hi guys,

I didn’t get much feedback on FB so I’ll post it here… hopefully I get some good feedback…
I would really appreciate it if you could spot code kinks or design improvement areas :slight_smile:

here’s the portfolio: http://codepen.io/balach/pen/JRPEop

and the Random Quote Machine: http://codepen.io/balach/pen/LRpEGQ

and Weather info: https://codepen.io/balach/pen/XjmXLq
** HELP: weather info doesn’t seem to work on my chrome version anymore, due to: getCurrentPosition() and watchPosition() no longer work on insecure origins. To use this feature, you should consider switching your application to a secure origin, such as HTTPS. See https://goo.gl/rStTGz for more details.

and the wikipedia Viewer: https://codepen.io/balach/pen/QKKqrL

I know I’m bundling a whole lotta stuff together… but in a way, it also shows a bit of evolution of the work, and trends (I know I could do with less shadows :P)

Looking forward to your feedback!

P.S. I do have previous experience with HTML, CSS, and JS, where I learnt some parts in quite some details as I needed them and promptly forgot them when I didn’t need them…


#2

Your portfolio looks good. I can’t wait to see the real projects added.

I like your random quotes. And, I can add to tweet.

Your weather is pretty, and it does say “Hello…” in the console. However, it cannot find me.Your codepen is at https. Perhaps add a search city ability?

Your wikipedia viewer doesn’t show if the page is not real. For instance “hawaii royalty” shows nothing (not even an error) but “royal hawaii” looks good.

I hope this is helpful to you.


#3

Thank you for the feedback @KoniKodes
I will re-do the profile next month (I’ll probably have to redo/fix the intermediate projects anyway again)…

I do have error handling on the wikipedia viewer, somehow it seems to really slow on codepen to show up… something to double check for me.

Regarding weather, I just checked and finding the location and getting the weather for it seems to work again (it has to be https for chrome as they disabled geolocation on non-secure hosts)… somehow the info is not shown anymore. I will look into it.

Thank you very much, it is very helpful, and highly appreciated!


#4

Let me know when it is where you want it. I think it will be awesome once everything is in place.


#5

Hey @balach !

You could use http://ip-api.com/ as an alternative to fetch location of a viewer. Works on all browsers.

Check out my Weather app if it helps :slight_smile:
https://s.codepen.io/nawazish/debug/xVmvgE

For portfolio you may refer here https://nawazishali.github.io/


#6

Hi Balach

I had a look at the wiki viewer. It might be an idea to add a loader so the user knows the page is doing something before the results return. http://loading.io/
You can put it a div and change its visibility in response to the ‘load’ event.

Cheers

Tom


#7

Thank you guys! means a lot.

@nawazishali cool website! I’ll take some inspiration :slight_smile:
@Loomernescent I’ll definitely add a loader, and perhaps build another one myself :slight_smile: it was quite fun doing the one for the weather app! looking at the ip-api as well
@KoniKodes thanks again!

Will keep you guys posted once I have done more!