Feedback on tribute page about Knut Hamsun

Feedback on tribute page about Knut Hamsun
0

#1

Hey all,

Here’s my tribute to Knut Hamsun. Feedback is welcome!

http://codepen.io/henrikpultzmelbye/pen/vKVOAA

Thanks,

Henrik


#2

Nice one. very clean and neat design


#3

Hi, @henrikpultzmelbye. Nice clean page :thumbsup:. However it breaks on smaller screens :frowning:. If you have time to spare, read about Bootstrap. Here are some links:

Bootstrap docs


#4

Hi :slight_smile:

The codepen linter throws this errors:

The “li” element cannot be a child of the “h3” element.

<ul class="col-xs-4 col-xs-offset-4">
          
       <div class="gray-border">
         <h3 class="text-center">Published books<h3>
        <li>Den Gaadefulde (1877)</li>
        <li>Et Gjensyn, episk digt (1878)</li>
        <li>Bjørger (1878)</li>
        <li>Fra det moderne Amerikas Aandsliv, artikler (1889)</li>
        <li>Sult (1890)</li>
        <li>Mysterier (1892)</li>
        <li>Redaktør Lynge (1893)</li>
        <li>Ny jord (1893)</li>
        <li>Pan (1894)</li>
        <li>Ved Rigets Port, skuespil (1895)</li>
        <li>Livets Spil, skuespil (1896)</li>
        <li>Siesta, noveller (1897)</li>
        <li>Aftenrøde, skuespill (1898)</li>
        <li>Victoria (1898)</li>
        <li>Munken Vendt, skuespil (1902)</li>
        <li>Kratskog, noveller (1903)</li>
        <li>Dronning Tamara, skuespill (1903)</li>
        <li>I Æventyrland, rejsebrev (1903)</li>
        <li>Det vilde Kor, digte (1904)</li>
        <li>Sværmere (1904)</li>
        <li>Stridende Liv, noveller (1905)</li>
        <li>Under Høststjærnen (1906)</li>
        <li>Benoni (1908)</li>
        <li>Rosa (1908)</li>
        <li>En Vandrer spiller med Sordin (1909)</li>
        <li>Livet ivold, skuespil (1910)</li>
        <li>Den siste Glæde (1912)</li>
        <li>Børn av Tiden (1913)</li>
        <li>Segelfoss by (1915)</li>
        <li>Markens Grøde (1917)</li>
        <li>Sproget i Fare, pamflet (1918)</li>
        <li>Konerne ved Vandposten (1920)</li>
        <li>Siste Kapitel (1923)</li>
        <li>Landstrykere (1927)</li>
        <li>August (1930)</li>
        <li>Men Livet lever (1933)</li>
        <li>Ringen sluttet (1936)</li>
        <li>Paa gjengrodde Stier, erindringer (1949)</li>
          </div>
          </div>

And the " /ul " element is missing.


#5

Hi, @erretres. Typically only <li> elements are directly nested in a list tag. It’s better to rewrite it as

<div class="gray-border"><!-- put your col-* classes at this `div` -->
  <h3 class="text-center">Published Books</h3>
  <ul><!-- col-* classes are intended for `div`s, as far as I know -->
    <li>...</li>
    <li>...</li>
    <li>...</li>
    ...
  </ul>
</div>

#6

Hi @kevcomedia, you’re right :slight_smile:


#7

Hey guys,

thank you for the help and thanks for link to the bootstrap explanation @kevcomedia . It’s more clear now, though not 100% yet. But I’m getting there. I’m on my portfolio page right now (my 2nd try) so I’ll look into it later. Thanks!