Feedback on Tribute Page and Portfolio

Feedback on Tribute Page and Portfolio
0

#1

I “finished” these a while back, but I haven’t finished with making them fully responsive on all devices. What do you guys think? Anything I should change?

Portfolio Page
Tribute Page

Thanks!
Seleah


#2

Hi @Seleah,

Tribute Page:

  • Is better not use the style attribute:
<h1 style="color: #900c3f" class= "font-weight-bold text-center">My Love, My Everything, My Amazing Husband</h1>

Because, you have multiple styles sources (That’s make the page more difficult to review.):

  • The CSS tab
  • Every element on the html with the style attribute

MDN documentation:
https://developer.mozilla.org/en-US/docs/Web/HTML/Global_attributes/style

The style global attribute contains CSS styling declarations to be applied to the element. Note that it is recommended for styles to be defined in a separate file or files. This attribute and the <style> element have mainly the purpose of allowing for quick styling, for example for testing purposes.


  • Do not use lower levels to decrease heading font size:
h1 style="color: #900c3f" class= "font-weight-bold text-center">My Love, My Everything, My Amazing Husband</h1>

MDN documentation:
https://developer.mozilla.org/en-US/docs/Web/HTML/Element/Heading_Elements

Do not use lower levels to decrease heading font size: use the CSS font-size property instead.Avoid skipping heading levels: always start from <h1>, next use <h2> and so on.

http://w3c.github.io/html/sections.html#the-h1-h2-h3-h4-h5-and-h6-elements

h2–h6 elements must not be used to markup subheadings, subtitles, alternative titles and taglines unless intended to be the heading for a new section or subsection. Instead use the markup patterns in the §4.13 Common idioms without dedicated elements section of the specification.

Common Idioms
https://www.w3.org/TR/html5/common-idioms-without-dedicated-elements.html#common-idioms-without-dedicated-elements


Cheers and happy coding :slight_smile:


#3

Wow, very detailed! Thanks so much! I have made the changes. :smiley: