Feedback Please

Code Feedback
1

Hey everyone,

I would love to hear your feedback on the tribute page i made . Also the page doesn’t seem to be mobile responsive. Any pointers on that?

Elon Musk

Many Thanks,
Akarsh

1 Like
2

It looks nice. Maybe you can add your name to the bottom of the page.

And I want to share my favorite tweet of Elon Musk: https://twitter.com/elonmusk/status/152599413813018624

3

Added name. Thank you! btw, good tweet :laughing:

4

It’s amaaazingg!!!

But not mobile responsive… I mean, it didnt change as I resized my screen…

Screenshot from 2016-06-06 12:34:18.png1366×768 600 KB

See what I mean? It did change, but I think you didn’t put all your content in a container class… I’d have a look at your code but I haven’t finished my own tribute page so I don’t consider myself qualified yet :stuck_out_tongue:

5

Hey, you are right, i did figure it out but i don’t know how to make it responsive yet . :stuck_out_tongue: I will work on that , and if i don’t succeed hopefully you will find time to look at my code and suggest some changes, Once you are done with your tribute , of course :smiley:

6

Hi,

Here’s one thing you can change. In your text css, you have this:

.text-pts{
  margin: 0 auto;
  border:5px;
  width: 1000px;
  font-size: 25px;
  font-family: 'Raleway', sans-serif;
  
}

Try removing the width. At the moment you’re telling the browser that the text should always use 1000px. So, when you resize the window, it will still be using 1000px. If you remove the width, then the text will just resize automatically to fit inside its parent div.

Regarding responsiveness, you can use media queries to have different rules depending on the screen size or device type ( https://developer.mozilla.org/en-US/docs/Web/CSS/Media_Queries/Using_media_queries ), however, you are using bootstrap as your framework, so you should not need to do anything, since bootstrap should take care of most things for you.

1 Like
7

That worked for me , Thank you :smile: