Feedback - React Markdown Editor

Feedback - React Markdown Editor
0

#1

I just finished my markdown editor project using react/redux and was hoping to get some feedback from the community. Please feel free to give constructive criticism of anything you find lacking.

App: https://www.samuelts.com/ReactMarkdownEditor/

Source: https://www.github.com/safwyls/ReactMarkdownEditor/

Cheers!
-Sam


#2

The UI / UX is really great and well made, so I won’t comment much on this.

The code itself is also pretty clear and concise. The only two “spots” that I can find if I want to be picky is:

1 - all your components can easily be written as functional components since they are only presentational:

export default class Header extends Component {
  render() {
    return (
      <div id='headerWrap'>
        <h3 id='title'><i class='fab fa-markdown'></i>|editor</h3>
        <MenuButton />
      </div>
    );
  }
}

// vs

const Header = () => (
      <div id='headerWrap'>
        <h3 id='title'><i class='fab fa-markdown'></i>|editor</h3>
        <MenuButton />
      </div>
 );
export default Header;

2 - Menu.js has 3 (or 4) tools markup that are almost identical. You can leverage JSX to loop through some data an avoid repetition.


Side note.
I assume you used Redux mainly for practice, and that’s ok. Just be aware that is a huge overkill for something this simple.


#3

Thanks for this, you’re right regarding redux I figured it was overkill for this but if I’m being honest it’s my weakest point of understanding in the front end right now so I was forcing myself to use it.

Also I see what you’re saying about the functional components and drying up the menu container, and that makes sense so I’ll push that change later today.

Thanks for the help!