Finished "Tribute Page" looking for feedback

Finished "Tribute Page" looking for feedback
0

#1

Just finished “Tribute Page” using only HTML and would enjoy some feedback!
Tribute Page via codepen


#2

Hi @robwgreenjr,

HTML inspector(codepen)

  • The <li> element cannot be a child of the <div> element.
    <li>John Fitzgerald Kennedy was born at 83 Beals Street in Brookline, Massachusetts, on May 29, 1917, to businessman/politician Joseph Patrick "Joe" Kennedy and philanthropist/socialite Rose Elizabeth Fitzgerald-Kennedy. His grandfathers P. J. Kennedy and Boston Mayor John F. Fitzgerald were both Massachusetts politicians. All four of his grandparents were the children of Irish immigrants.</li>
      </div> 
   <div class="col-sm-4">

MDN documentation:
https://developer.mozilla.org/en-US/docs/Web/HTML/Element/ul

Permitted content
zero or more <li> elements, eventually mixed with <ol> and <ul> elements.

Cheers and happy coding :slight_smile:


#3

I would not use ul and il … keep content inside the div since you have Botstrap to control the grid :wink:


#4

Thanks, i will make these changes.