First in the World - Tribute Page - Fedor Konyukhov

First in the World - Tribute Page - Fedor Konyukhov
0

#1

Hi Campers,
Please leave your feedback and suggestions :innocent:
Tribute Page - Fedor Konyukhov


#2

Hi @kuznetsovandrey76,

This code is not correct:

  <h1 class="text-uppercase">Fedor Konyukhov</h1>
  <h4>An Aerostat Balloon Pilot, and a Yacht Captain, Fedor has circumnavigated the globe four times, and has crossed the Atlantic Ocean fifteen times, including a row boat crossing.</h4>

MDN documentation:
https://developer.mozilla.org/en-US/docs/Web/HTML/Element/Heading_Elements

Do not use lower levels to decrease heading font size: use the CSS font-size property instead.
Avoid skipping heading levels: always start from <h1>, next use <h2> and so on.

http://w3c.github.io/html/sections.html#the-h1-h2-h3-h4-h5-and-h6-elements

h2–h6 elements must not be used to markup subheadings, subtitles, alternative titles and taglines unless intended to be the heading for a new section or subsection. Instead use the markup patterns in the §4.13 Common idioms without dedicated elements section of the specification.

Common Idioms
https://www.w3.org/TR/html5/common-idioms.html


Is better not use the style attibute:

...
 <div style="width: 90%;">
                <dl class="dl-horizontal">
                <dt>1981</dt>
...
 <p style="text-align: left;">"By the age of fifty he had achieved more than forty unique expeditions and ascensions and had illustrated his vision of the world in countless paintings and books"</p>

Because, you have multiple styles sources (That’s make the page more difficult to review.):

  • The CSS tab
  • Every element on the html with the style attribute

Cheers and happy coding :slight_smile:


#3

Thank you, everithing changed :ok_hand:. I will try to follow your, MDN and w3c advice


#4

You’re welcome :smile: . The mdn is a really good reference not only for html the javacript section is really helpful.

Cheers and happy coding :slight_smile: