First project tribute page-feedback please!

First project tribute page-feedback please!
0

#1

#2

Nice!

In codepen.io, you don’t need write the and tags. :slight_smile:

On the last button, there’s a typo: target+ instead target=

<button type="button"><a href="https://en.wikipedia.org/wiki/Adventure_Time" target+"_blank">Check it out!</a></button> on>

Thus, the link opens in the same tab.

Since you’re using bootstrap, in my opinion, you can set your image responsive too (see img-responsive).

Avoid inline styles, they make the code maintainability/readability difficult. You can write all the styles on the css file, using the right selectors.

Congrats again, good job!


#3

Hey thank you so much for taking your time to look it over! You are totally right, I am starting my next project tonight, the personal portfolio page. I will leave all the styling to css.


#4

Hi

<header class="container">
  <div class="row text-center">
      <h1 >Jake The Dog!</h1>
...
<section class="jumbotron">
    <div class="container">
      <div class="row text-center">
        <img src="http://vignette2.wikia.nocookie.net/adventuretimewithfinnandjake/images/0/0b/Blush.jpg/revision/latest?cb=20131031114000">
      </div>
...
<section class="container">
  <div class="row text-center">
    
    <em><p style="font-family:Verdana">"There is a tale of a dog tail, that belongs to Jake the dog. Famed adventurer from the land of Ooo."</p></em>

http://getbootstrap.com/css/#grid-intro

Content should be placed within columns, and only columns may be immediate children of rows.

Codepenlinter : The “p” element cannot be a child of the “em” element.

<em><p style="font-family:Verdana">"There is a tale of a dog tail, that belongs to Jake the dog. Famed adventurer from the land of Ooo."</p></em>

Cheers and happy coding :slight_smile: