freeCodeCamp Algorithm Challenge Guide: Seek and Destroy

DulajChathuranga · 2017-04-08 08:31:46 UTC

Basic, but long code.

function destroyer(arr)
{
  // Remove all the values
  
  //Turn to a real array
  var args = [];
  args = Array.from(arguments);
  
  var filtered = [];
  var val;
  
  //Filter 'argument[0]'(args[0])
  for (i = 0; i < args[0].length; i++) //args[0]
    {
      for(j = 1; j < arguments.length; j++) //args[1] =<
        {
          if(args[0][i] == args[j])//Check whether args[0] elements equal to others
            {
              break; // Stops if equal, lead to check next args[0] element
            }
          else
            {
              val = args[0][i]; 
              
              //Push only after checked by all following args
              if (j == arguments.length - 1) 
                {
                  filtered.push(val);
                }
              continue;
            }
        }
    }
  return filtered;
}

destroyer(["tree", "hamburger", 53], "tree", 53);

namrata1011 · 2017-04-13 18:42:42 UTC

The output is correct for all cases. But still, the code is not accepted. Where’s the problem?

function rem(value) {
  return value !== this; 
}

function destroyer(arr) {
  var args = Array.from(arguments);
  for (var i=1; i<args.length; i++) {
    arr=arr.filter(rem, args[i]); 
  }
return arr;
}

medjosh · 2017-04-15 17:31:02 UTC

Here is mine using .include()

function destroyer(arr) {
  var args = Array.from(arguments);
  var firstArg = args.shift();
    
  var returnedArg =[];
  
  for (i=0; i<firstArg.length; i++) {      
    if (args.includes(firstArg[i])===false){
    returnedArg.push(firstArg[i]);
  }}
  
  return returnedArg;

  
}

destroyer([1, 2, 3, 1, 2, 3], 2, 3);

Logic: If something in the array is not in the arguments, then put that number from array to a new array.

greg-wolff · 2017-04-22 20:33:03 UTC

My ES6 “one-liner”:

function destroyer(arr) {
  return arr.filter(x=>![...arguments].slice(1,arguments.length).includes(x));
}

adelrodriguez · 2017-04-26 03:53:18 UTC

Here’s my solution. Using .filter and .indexOf:

function destroyer(arr) {

  var args = Array.from(arguments);
  
  var result = args.shift().filter(function (value) {
    if (args.indexOf(value) < 0) {
      return true;
    }
  });
  
  return result;
}

jlandrian · 2017-05-16 21:52:41 UTC

Hi, I was doing fine on all of the other exercises until this one. Can someone explain why filter(Boolean) only returns true values? I thought that Boolean evaluated to true OR false?

marikah · 2017-05-17 02:56:04 UTC

Here´s my version using the same tricks. This was a tough one for me but I am glad I took the time and effort and now I actually understand the idea of the callback function.

function destroyer(arr) {

var myArr = [].slice.call(arguments, 1);

var finalArr = arr.filter(function(x) {

return myArr.indexOf(x) === -1;

});

return finalArr;
}

ParalysedBeaver · 2017-05-20 21:10:48 UTC

I kept using arguments inside the callback function of filter, and was wondering for the longest time why it wasn’t working.

tom42s · 2017-06-01 12:27:50 UTC

Managed to simplify it down to this after lots of playing around.

function destroyer(arr) {
  var args = Array.prototype.slice.call(arguments);
  return args.shift().filter(function(initial){return this.indexOf(initial)<0;},args);
}
destroyer([1, 2, 3, 1, 2, 3], 3, 2);

Gauravkumar10094559 · 2017-06-01 15:30:05 UTC

// without filter
function destroyer(arr) {
var l=arr.length*arguments.length;
var i=0,j=0,k=1;
while(i<l)
{
if(arr[j]===arguments[k])
{
arr.splice(j,1);
k=1;
}
else{
k++;
}
if(k==arguments.length)
{
j++;
k=1;
}
i++;

return arr;
}

TeeJay · 2017-06-10 04:04:55 UTC

I don’t understand why my code wont pass. Can someone please enlighten me?

destroyer([1, 2, 3, 1, 2, 3], 2, 3);

MarioAleixo · 2017-06-18 18:45:20 UTC

Hey TeeJay,

The increment operator (++) is supposed to go after the integer variable, so it should be i++ and j++ in your for loops.

The condition for your if statement dictates that if a value in arguments[0][i] is equal to the arguments we are trying to exclude from the array (i.e. arguments[j]), it should be pushed to newArr. What this means is that you’re actually pushing the values you don’t want to the new array. Instead of pushing those values to newArr, you could simply delete them from arr. This also means you no longer need use a new array.

The else statement you implemented also meant that whenever your if condition was false, the for loops would be broken out of (which isn’t what you want as you want the for loop to iterate over all the values in arr), and nothing would be returned as you didn’t place anything after the return keyword. The else statement is actually unnecessary, as shown in my reworking of your code below.

Using the delete keyword to remove the unwanted values from arr leaves null values in their place and you’ll end up with:
[1, null, null, 1, null, null]

So, when returning arr, filter out the null values using arr.filter(Boolean);.

I reworked your code as follows and it now passes:

function destroyer(arr) {
  for (var i = 0; i < arguments[0].length; i++){
    for(var j = 1; j < arguments.length; j++){
      if (arguments[0][i] === arguments[j]){
        delete arguments[0][i];
      } 
    }
  }
  return arr.filter(Boolean);
}

This solution above is quite similar to the Basic Code Solution, minus the use of Array.prototype.slice.call() to create an array of arguments.

I hope I’ve helped.

TeeJay · 2017-06-18 19:06:41 UTC

Thank you @MarioAleixo! I had been scratching my head on this one for a while. Great explanation and you also helped me understand why we need to filter the Boolean values.

johnnyosullivan · 2017-06-29 20:34:59 UTC

I really appreciate all the help I get in these guides, but I just wanted to say that the second hint threw me a bit of the scent on this challenge and that the ultimate solution was pretty much what I was thinking it was going to be before I read the hints. I know I should have tried to write the code as I saw it in my head before looking for hints, but just throwing it out there that maybe Hint 2 could be removed or changed because I don’t think there are many solutions that actually use those methods.
Again, thanks for all the help.

YesImChuck · 2017-06-30 02:53:35 UTC

This is my solution here. Tried to make it simpler.

function destroyer(arr) {
  // Remove all the values
  var targets = Array.prototype.slice.call(arguments, 1);
  
  var results = arr.filter(function(e) {
return this.indexOf(e) < 0;
  }, targets);  
  
  return results;
}

destroyer([1, 2, 3, 1, 2, 3], 2, 3);

HTM-ell · 2017-06-30 15:06:35 UTC

How does val get initiated of defined in the intermediate explanation?
I’m not understanding that particular part.

Thank you

DonMatano · 2017-07-01 05:45:03 UTC

This is because he used the filter() method on the array arr. With this method it passes each and every element in the array arr to the variable val one at a time.

This is the Syntax of filter method

array.filter(function(currentValue, index, arr), thisValue)

where currentValue :- is the current element of the array that is given to the function. I.e in our case the variable val,

index, arr and thisValue are optional and aren’t used in the example.

More Useful links below:-
https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Global_Objects/Array/filter

DevMaterial · 2017-07-04 02:30:58 UTC

This is my solution. I decided to use some ES6 because I got a little bitter looking at all the extra code.

var args = Array.prototype.slice.call(arguments, 1);
  
return arr.filter(function(val){ return args.every(x => x !== val); });

I tried to use for loops as little as possible.

EDIT: Decided to change the empty arg array and for loop in favor of Array.prototype.slice.call(arguments, 1); that everybody has used. Never thought about it and did some research on it on the MDN.

benjaminadk · 2017-07-04 08:40:27 UTC

i get the destroyers with spread operator minus the first argument
then filter the first argument aka the array
num is each item in the array
only nums that aren’t in the destroyers array get returned

Aiden · 2017-07-05 03:59:36 UTC

my solution

create a fiterList to store extra arguments that after arr (more about arguments object)
create a filter function for arr by indexOf

function destroyer(arr) {
    var filterList = [];
    
    for (var i = 1; i < arguments.length; i++) {
        filterList.push(arguments[i]);
    }

    return arr.filter(function(val) {
        return filterList.indexOf(val) < 0;
    });
}

destroyer([1, 2, 3, 1, 2, 3], 2, 3);