George R.R. Martin Tribute Page

George R.R. Martin Tribute Page
0

#1

Well, I started a couple of days ago and today I went all in and tried to do this Project. It’s my first time doing something like this, so i’m looking for some feedback, maybe point me out any mistakes you can find.
I know It’s really basic, I haven’t submitted it for the challenge yet, I want to practice some more and then make something a little better.

Project Link - http://codepen.io/Vampirro/full/rLgYWK/


#2

I don’ think that it is any more basic than most of the other tribute pages I’ve seen.

My only real feedback is that the “Awards Won” and the “Biography of Novels” sections, might be a little difficult to read because of the background/font color combination.

Other than that, I think it looks fine.

Nice work!


#3

Hey not bad for your first project :thumbsup:

In the awards section wrap the years in <strong> tags so they stand out better (or separate them with a dash).

Also, the name is so large that when viewed on a phone, the name “spills” to the side.

You’ll have to use media queries to make up for this. This is a quick example

h1 {
  /*   remove the font-size */
  text-align:center; 
}

@media (min-width: 768px) {
  h1 {
    /* and move it here */
    font-size: 550%;
  }
}

This may be a lot to grasp, but what it does is it checks if the viewport is at least 768px wide. If so, the CSS inside is applied to the page. In this case, you want to apply the font-size when the viewport width is at least 768px wide. I used min-width: 768px because it’s consistent with Bootstrap’s media queries.