Help! Personal Portfolio Project

Help! Personal Portfolio Project
0

#1

Hi, need help to solve the height of the welcome section should be equal to the height of the viewport issue.
even if I have use { height: 100vh }, I still can’t passed the test - any pointers what I should do here?

link to my codepen: https://codepen.io/nath889/pen/NENPMr


#2

Can you provide a link so we can see the code in action? Maybe codepen?


#3

Ah sorry! should’ve included the link early on:


#4

The problem was that you put a 1px border on the bottom and it, by defaults, goes outside the bounding of the rectangle. So, your #welcome-section always had 1px more than the height of the viewport. You can add box-sizing: border-box to it and the border now will count as part of the rectangle.

box-sizing: border-box;
height: 100vh;
border-bottom: 1px solid silver;

#5

thank you!!! it solved the problem :smile: