I have redesigned my tribute page

I have redesigned my tribute page
0

#1

Hi Campers, I have redesigned my tribute page since I couldn’t complete all the projects before freeCodeCamp got major updates. Here is the codepen link https://codepen.io/picklu/full/mPWyaB/. This time I am committed to myself that I will complete all the responsive web design projects. I am not sure how the projects are considered qualified. Is it okay if I only use classes for styling and leave the ids for the freeCodeCamp test suite? Appreciate any comments or suggestions.


#2

It doesn’t matter as long as you pass the tests.

Looks pretty good to me :slight_smile:


#3

Thank you, shimphillip.


#4

No, your page should look good and tests should came second.

FCC is for learning, not trying to past the annoying tests.

@picklu Your page looks great either way if it passes or not.

1914 - Ramanujan travelled to England in 1914

i n fi n i t y


#5

Learning to pass the tests (the user stories) is definitely something that should come first. The final styling is important also, but the client/employer will want the user stories filled. Without the structure (ids and class names), tests can not be built to validate the structure is still intact when changes are made to the design.

You should not try to hang pictures on a wall if you have not built the wall yet.


#6

These tests are absolutely useless when it comes to learning. They fail to help structure the web page what so ever, or help you in the first place.

Too many times i see people say a good looking project is not good because it doesn’t pass 1 test, or a bad looking project is good because 14/14 tests past.

The tests are completely unrealistic. I highly dout a local business cares about the ID of the header. They care if they have a header in the first place.

Instead of showing people lots of different example headers, footers, designs, etc. You get this:

User Story #1: I can see a main element with a corresponding id=“main-doc”, which contains the page’s main content (technical documentation).
User Story #2: Within the #main-doc element, I can see several section elements, each with a class of main-section. There should be a minimum of 5.
User Story #3: The first element within each .main-section should be a header element which contains text that describes the topic of that section.

see how useless this is? making some of these projects would be self explanatory if you just looked up examples and got ideas that way.


#7

I do agree with your thinking. That is why I kept aside those instructions from the design decisions of my project. I think we should come up with new ideas to set up some criteria to grade the developers. But the problem with your “User story” idea is that it needs a lot of expert people to grade the projects.


#8

I read @shimphillip comment as a response to this question (maybe I’m wrong).

I am not sure how the projects are considered qualified. Is it okay if I only use classes for styling and leave the ids for the freeCodeCamp test suite?

@michaelnicol
Passing the test is part of the assignment. Like it or not, the student doesn’t get to dictate the rules of assignments. You can’t have automated tests without fixed parameters, and you definitely can’t make them judge looks. Having said that, i do understand, and at least partly agree, with what you are saying. Yes, the page should look “good”, and yes effort should be put into making a nice looking page. But that doesn’t mean you can’t pass the tests.


#9

I should really have commented on your page. You are looking for feedback, not for your thread to be hijacked.

I think it looks pretty good, the hover effects might be a bit too many/strong/distracting. They make it a little hard to focus on the information on the page. But we are allowed to have fun and i quite like the pseudo element spinny things (is spinny a word?), so it’s cool i guess. Good work.


#10

Thank you. I really appreciate all of your comments. At first, I made the tribute page without any hover effect. Then I thought why not use the hover effect since I am still learning.


#11

Most of the project review section is

“14/14 tests past for me, its great”

Its very rare i see actual in depth reviews on peoples projects, which s why i am constantly on here to properly review them. Its almost like what people want to hear what they need to hear.

This is a online bootcamp, not HS. You are here to learn how to make webpages, not make sure 14/14 of the unrealistic tests pass to make it suddenly good. I highly dout a client will ask for this header id, and this section id, etc.

The tests are easy that i would do them if a client asked me, but its annoying and useless currently. The tests don’t help you what so ever.


#12

Couldn’t agree more!


#13

@michaelnicol [quote=“michaelnicol, post:11, topic:225784”]
The tests are easy that i would do them if a client asked me, but its annoying and useless currently. The tests don’t help you what so ever.
[/quote]

The particular tests for this challenge may not seem important to you now, but when you actually start writing apps with thousands of lines of html and you want to make sure when someone makes a change to some part of the html, that it does not change the original assumptions about the html structure needed (a user story or project requirement), then you will be glad you have tests which can be ran automatically to validate the original structure is not changed.

You may be thinking someone will be able to just look at the page and know something has changed without using tests to validate certain html elements still exist. If various parts of the page are hidden and only made visible under various circumstances, then a human could easily miss seeing something that should be there. That is especially true if you have hundreds of elements with various states of visibility and hundreds of scenarios that someone would manually have to test out.

That would be a waste of valuable time and still could result in errors. By writing automated tests to validate the design is still intact is extremely useful in the real world of professional development.

You may not have worked on projects of the scale I have seen (think 100K lines of html/js, and php), but having tests helps greatly to find layout problems before an end user finds them.

Just keep in mind, you may not be in control of the user stories / overall design plan or designing the tests for the user stories. This is why it is important to get used to writing code based on these types of user stories now. If it seems trivial to you based on these small FCC projects, that is great. However, that does in no way mean it is not important to learn how and why we develop based on user stories.

This is the last post I am going to post on the subject as both of us have stated our opinions multiple times. Let’s keep any further in this thread about the OP’s Tribute project. If you want to discuss further, then send me a private message.


#14

If you were going for the look of a report, you nailed it! I don’t see anything wrong with it.