I want feedback on my first project

I want feedback on my first project
0

#1

I would love any feedback on my first FCC Project. The Tribute Page.
https://codepen.io/gphuyel93/full/MqNRbX/


#2

Great job.

Pros:

  • First off, you chose an awesome group of soldiers to write a tribute to. Seriously, great choice.
  • I really like the title font. It actually looks like a ‘playful’ graphic.
  • I like the ‘advertising’ look at the bottom of the page (… time to sign up for adventure).

Cons:

  • Not so sure about your font-color choice? Might be hard to read for people who can’t see those color ranges, since yellow blends easily into a blue background.
  • You can use margins between the <li> tags, instead of relying on <br> tags for spacing.
  • Lastly, think of <header>, <main>, and <footer> tags in the same way they’re used on a paper report. Review Mozilla’s specification of the tags .

#3

Thanks for the suggestion. Will fix it.


#4

Great job on the fixes. Your code looks clean, and so does your site. Again, I can’t emphasize enough what a great selection you picked to dedicate a tribute towards.