Just finished FCC's 1st Project! Feedback?

Schultzie67 · April 13, 2018, 12:28am

Any and all feedback is encouraged! Thank you!

Build a Tribute Page

JohnnyBizzel · April 13, 2018, 12:57am

It’s not responsive. Bootstrap is good for this purpose!

Schultzie67 · April 13, 2018, 2:54am

How are you able to tell whether the website is responsive or not?

jester070993 · April 13, 2018, 2:56am

Resize window, open page on mobile, etc. stuff like that

Schultzie67 · April 13, 2018, 4:24am

I’ve almost got the responsiveness on the top half working properly. When I have the webpage on full-size desktop mode, the caption’s silver background doesn’t line up with the border on the image. But on mobile, and other resizings, it matches up perfectly. Do you know how to fix that?

Thanks for the help by the way!

jester070993 · April 13, 2018, 4:48am

.silver-background  {
  background-color:  silver;
  display:inline-block;
}

if you want it to wrap just around the text itself then, display: inline-block

which works in respect to height and width of an element

Schultzie67 · April 13, 2018, 5:02am

I would like the silver background of the caption to be in line with the border of the image, instead of wrapped around the text itself.

JohnnyBizzel · April 13, 2018, 9:33am

This is what I mean by not responsive:

Also, please read up on accessibility and why “here” is not used for hyperlinks:

Schultzie67 · April 13, 2018, 3:24pm

Thanks for the suggestion, I think everything is working properly and looking good!