My Random Quote Machine <good,could be better, terrible?>

Code Feedback
1

Here is a link to my just completed Random Quote Machine:


Your feedback is welcome. Thanks.

1 Like
2

These are some fun quotes, and it runs smooth.

This is what I saw when I tried to tweet:
Minds are like parachutes. They only function when open. Source:Thomas Dewar #quotes

I donā€™t think you want to send #quotes to twitter.

1 Like
3

Actually I did, as an hashtag. I included it in the twitter api link. You can check it in the js section if you want.

4

You are sending the words #quotes, when you only want to send the quote and author.

Try something like this: (ā€œhttps://twitter.com/intent/tweet?text=ā€ +quote + " " +author);

5

I wanted to send the quote and the author. But I also wanted the tweet to have the hashtag #quotes, So that when the user tweets it, displays:
Quoteā€¦ Source:ā€¦ #quotes

6

Ok, that makes sense. Then you may need to add the actual url instead of hashtag.
Let me look again.

7

Here:
ā€˜https://twitter.com/intent/tweet?hashtags=quotes&text=your_textā€™

8

I see what you are trying to do: Iā€™m not sure why it is not showing the actual link ā€¦

hashtags optional
Allow easy discovery of Tweets by topic by including a comma-separated list of hashtag values without the preceding # character.

Example Value: nature,sunset

url optional
A fully-qualified URL with a HTTP or HTTPS scheme, URL-encoded. The provided URL will be shortened with Twitterā€™s t.co to the number of characters specified by short_url_length.

Example Value: http:%3A%2F%2Fexample.com%2F

https://dev.twitter.com/web/tweet-button/web-intent

9

Oh, you meant on the website? I actually got the idea from the project example page. If you hover over the tweet button, youā€™ll see the link.

10

I see what you are saying. I guess Iā€™ve just never seen it before.

I donā€™t look at the example page, I just follow the user stories:
User Story: I can click a button to show me a new random quote.
User Story: I can press a button to tweet out a quote.

Okay, then. It looks good. The quotes are good, and the tweet button works.

11

Hey, you canā€™t tweet the first quote?

12

I was able to:

But clicking on #quotes took me here:

Pasted image605Ɨ582 80.5 KB

I expected it would take me to the orginal url.

1 Like
13

Thatā€™s normal behaviour for a hashtag, I believe.

14

I think you are right. It is a good reminder of where expectations leadā€¦

15

you were transferred to your own twitter account. And from there, everything works like twitter should.

16

I uh, used it as a placeholder, before users click the new quote button. Iā€™ll see about fixing that Ben.

17

That makes sense. Thank you.