My Random Quote Machine - in need of code review

My Random Quote Machine - in need of code review
0

#1

Hello.
I finished my Random Quote Machine over 2 weeks ago. I’ve realised that in order to progress I need to acknowledge my mistakes. I’d be grateful if you could check out my code and review it.

See the Pen Random Quote Machine by kborzecki (@kborzecki) on CodePen.


#2

I like it (and the color changes are really neat). Functionally, it works great. If you wanted to, you could automatically truncate tweets that go beyond twitter’s character limit… but the way it is now works fine too.

Looking at your code, I think that you could move the listOfColors variable inside the colorChange function and out of the global scope, but other than that I don’t see a whole lot I would change.


#3

Thank you.
I’ve moved the list to the color function as you suggested.