My Tribute Page project, need feedback

Code Feedback
1

https://codepen.io/CrazyDiamond4811/full/dyoaoNa Please give me feedback.

1 Like
2

I would suggest a few things:

  • Put a max width on the text content. Too many words per line is hard to read. Also, add some line height so the lines have a little more space between them.
  • A lot of people frown upon having large blocks of text centered. I would change it to left justified.
1 Like
3

Thanks for the answer.
I’ll fix this.

4

https://codepen.io/CrazyDiamond4811/full/dyoaoNa
Better?

5

Well, not as good as it could be. Putting a percentage on the max width still allows for very wide content in browsers that are opened very wide. What other units do you think you could use to limit the max width (and don’t say pixels). OK, you can say pixels, most people will. But for a truly responsive design, I would use a different unit.

Also, I think you’ll probably want to center the content on the page as well.

1 Like
6

I should use “em” for max-width?
how i center the content on the page?

7

Yes, I like ‘em’ better because it allows you to control the number of characters per line better. But like I said, most people would use pixels, so feel free to do that as well.

For your second question, google ‘CSS centering content’. In fact, I would suggest that the first thing you do with any question is to google it and see if you can figure it out on your own. Because that’s what professionals actually spend quite a bit of time doing, so you might as well get in a lot of practice :slight_smile:

1 Like
8

Thanks.
Google will be my best friend.

9

https://codepen.io/CrazyDiamond4811/full/dyoaoNa

Is it good now? it’s the first time i do this.

10

As far as the issues I brought up, yes, they look much better now, don’t you think?

Personally, I think you should break that one big block of text into multiple paragraphs because a lot of people are going to find it hard to read as it is. And you’ve got some typos (such as the “Carrer” header).

It does pass all the tests, so I think you are good to go there. But as far as “is it good?” I think that’s for you to decide.

Good luck and have fun.

1 Like
11

Thanks for the help.

12

Welcome to the forums @Crazycamper. Your page looks good. This is a nit but codepen only expects the code you’d put within the <body> </body> tags in HTML. (No need to include the body tags). For anything you want to add to <head> click on the ‘Settings’ button, then HTML and add it into the ‘Stuff for <head>’ box.

  • I mention because you have <head> </head> tags in what would essentially be the body and they don’t belong there. If you want to add a title click the ‘Settings’ button and add it there.
1 Like
13

Thanks.
I’ll fix this.

14

I think it looks nice! Nothing I would change :wink:

1 Like