Need feedback for Tribute Page-Project of absolutely newbie

Code Feedback
1

Hi! I’m a newbie here. I have finished my tribute page, one problem is about the tribute-link, the a:visited on CSS doesn’t work. I can’t figure out why…If you could help me with that it will be awesome :slight_smile: and if you see any flaws please address it so I can work on that.

Here is Tribute page.

Thanks! and I’d really appreciate any feedback.

2

Page looks good, css is solid, very very nice. Margins are a little wide for my taste, and I have never been a huge fan of black backgrounds, but it’s clean and readable.

One thing that I might suggest, in looking through your code, I notice you use the figcaption tag, which is great - it’s semantic HTML, and it makes your code self-documenting. But… that tag is normally placed inside another one (where you used the div to wrap them, consider the figure:

<figure id="img-div">
  <img src="..." alt="description of image" />
  <figcaption>This is the caption for that image, encapsulated together.</figcaption>
</figure>

It’s sort of like the “group by” thing in design software - you use the figcaption to group both the image and its caption into a single unit. Not strictly necessary, but I think you might find it useful.

As I said code looks great! Love that there a minimal divs, and the media queries look solid. Nice!

1 Like
3

Thank you so much for taking your time to give me the feedback and advise I will look into that.

1 Like
4

Nice! The :visited seems to be working for me. It could be because you have a color that’s very similar to what the link is to begin with. Maybe try changing it to a different color and see if it works then.

2 Likes
5

It works for me now…I think I was confused by the the two similar color. LOL
Thanks for taking a look on my project :slight_smile:

2 Likes
6

Page looks good to me. Code seems good, I am a newbie myself.

If I was to suggest improvement on something perhaps it would be better fonts, colours and positioning of things to make it look better.

7

Hi @Kesinee, your page looks good. There are some things you may want to revisit;

  • codepen provides validators for HTML, CSS and JS. Click on the down arrow in the upper right of each section and then click on the respective ‘Analyze’ link.
    • In HTML this will show that the figcaption element cannot be a child of <div>. In CSS you have a missing semicolon
  • Work on the responsiveness some more. On a smaller screen, things start to fall apart and not look so well. You can resize your browser to see what I mean.
2 Likes
8

Thanks for very useful info! I will fix it when I get home on Sunday.

1 Like