Need some feedback on my tribute page

Need some feedback on my tribute page
0

#1

Any feedback is welcomed. Especially any tips on cleaning up/organizing the code as I feel its a bit messy but hey, for my first project I’m feeling pretty good about it. thanks! :slight_smile: https://codepen.io/TimeIsOnMySide/full/xEGYgN/


#2

According to MDN, you should replace <image> with <img>.

This feature is non-standard and is not on a standards track. Do not use it on production sites facing the Web: it will not work for every user. There may also be large incompatibilities between implementations and the behavior may change in the future.

Try to avoid using inline-styles in your code.

<p3> is not a valid HTML tag (afaik). Use <p> instead.

The outermost <div> 's closing pair is missing.

In

<footer><cite>Rolling Stone Magazine</footer></cite>

you should close <cite> first.


#3

Thank you thats all very useful! will definitely be revising this. Can I ask what the disadvantage to using inline styles is?


#4

Inline styles tend to clutter your HTML code. Let the styles be defined in a separate (CSS) file (it’s easier to look things up in there). Also if you have repeating inline styles in your HTML, and you wanted to change them, you’ll have to look for all of them, which can give you a hard time.