New portfolio page, constructive feedback?

Code Feedback
1

Hey there, I just completed my portfolio page. For some reason I’ve been putting off this project…for like a year…Anyway, I finally felt like doing it today, so I busted it out. Here’s the link: http://twalton-portfolio.surge.sh
Comments / constructive criticism are welcome. Thanks!

1 Like
2

Looks good. Just stylistically, I might round some of those corners on this images and icons - a pet peeve of mine.

3

I like the look of it. It has a modern feel. I would recommend adding links in each section that take you up to the top, or have a sticky nav bar.

1 Like
4

Good suggestion about the links, thanks!

5

Have you tried using a validator?

https://validator.w3.org/nu/?doc=http%3A%2F%2Ftwalton-portfolio.surge.sh%2F

I think you can ignore the error about the | character being illegal in the <link>'s href attribute, since there’s nothing you can do about it.

I’d personally use a placeholder image with some text in it, just to be clear that the squares are indeed placeholders. You can easily get them from https://dummyimage.com/

1 Like
6

Interesting, the link is a direct paste from fonts.google.com. I use a linter when writing code but I haven’t bothered with it for html. I should probably do that. Thanks for the head’s up.

I’ll be replacing those placeholder images soon. =)

7

I like the look! Other than that, maybe it’s just me but the background image took a bit to load; not sure if this is a x-large image getting resized down considerably, or if the rendering time is intentional, just pointing it out as it’s the first thing I noticed. Other placeholder resources include but aren’t limited to: http://placehold.it/, http://placem.at/ and my personal favorite (most of the time) http://www.fillmurray.com/

1 Like
8

Yes, the image takes some time to load. I wanted it to be nice and sharp so it’s kind of big. I’m not sure if I can optimize such a big image to load more quickly.

9

There are a few things you can do, resizing of course being one of them. But for brevity’s sake, this resource - https://tinypng.com/ - can help a lot, it will regenerate your image into a file of a much smaller size whilst preserving aspect ratio.

I copied your image which in its original file size is ~3.48MB and it returned a file of ~1.16MB. I then did some stare & compare and really there isn’t any glaringly discernable difference between the original and the regenerated version.

10

Thanks, I optimized that image. A lot better now.