Personal Portfolio - pending review

Code Feedback
1

Hi everyone.

Check out my personal portfolio project: https://codepen.io/bigfatpartyguy/full/poogxWo

I’ll be appreciated for any constructional criticism.:face_with_monocle:

Thanks.

2

Nice! Impressed. Looks way better than what I did but I think the essence of the contact section is to make it easier for people to get in touch and others may prefer other means of communication than the email alone. So for me I will say you can improve that section and add other means of communication if you have them. Just my opinion though but nice work. :smile:

1 Like
3

the scroll-behavior isn’t a correct code

5

Hmm, didn’t think about it from this point of view.:thinking: I will try to rebuild contact section, thank you.:upside_down_face:

6

Could you explain why?

7

yes because codepen io gives an error message. whichs mean it is incorect

8

It’s strange. I don’t have any errors related to scroll-behavior in codepen. Could you describe in more detail what type of error you have, or attach a screenshot of an error?

9

22
22824×536 38 KB

sure here u go

10

I also have a question about your code

2. The welcome section should have an h1 element that contains text.

But when I look at it I see the next
could you explain to me how that works
and why they are so many numbers in the path? i want to know what they do?

<h1>
      <span class="name-half">
        <span class="name-left">maxim</span>
      </span>
      <a class="home-logo" href="#">
        <svg id="logo" data-name="logo" xmlns="http://www.w3.org/2000/svg" viewbox="0 0 297 297">
          <title>logo</title>
          <circle cx="148.5" cy="148.5" r="148.5" fill="#141d1f" />
          <path
            d="M227.31,232H211.69a4.69,4.69,0,0,1-4.69-4.69V124.79a4.69,4.69,0,0,0-9.13-1.47l-26.6,80.25A18.15,18.15,0,0,1,154,216H143a18.15,18.15,0,0,1-17.23-12.44l-26.6-80.25A4.69,4.69,0,0,0,90,124.79V227.31A4.69,4.69,0,0,1,85.31,232H69.69A4.69,4.69,0,0,1,65,227.31V93A28,28,0,0,1,93,65h10.23a4.69,4.69,0,0,1,4.46,3.25L147.29,191h2.42L184.07,84.43A28,28,0,0,1,210.74,65h16.57A4.69,4.69,0,0,1,232,69.69V227.31A4.69,4.69,0,0,1,227.31,232Z"
            fill="#f2f2f2" />
        </svg>
      </a>
      <span class="name-half">
        <span class="name-right">morozov</span>
      </span>
    </h1>
11

Ok, text inside h1 heading element (and in other heading elements or other block elements like p element) can be represented as plain text or it can be wrapped for example with generic span container. So in the same fashion other inline elements can be placed inside h1, such as a, img, span, svg…

As for path: path is used to define a shape of SVG element, and characters and numbers are commands and coordinates respectively, used to create a shape.
You can read more here: https://developer.mozilla.org/en-US/docs/Web/SVG/Tutorial/Paths
Actually I haven’t hard-coded SVG element, I drew an image in Illustrator and then export it as .svg.

1 Like
12

Finally I figured out what was the problem with scroll-behavior. There are no any errors. It seems like you are using “Panda” theme for syntax highlighting and it appears to be some bug of this theme and some of others too.
Try to switch your syntax highlighting theme in your codepen settings to something like “Twilight” or “Tomorrow Night” and you’ll see that there are no problems with scroll-behavior highlighting.:wink:

1 Like