Please review my tribute page (Peter Sagan)

Please review my tribute page (Peter Sagan)
0

Hi All,

I’ve come back from coding after quite a long break - essentially starting from scratch!

I’ve been working back through the free code camp curriculum (As well as some other options including P1xt’s guides) in the last few days - I got to a point where I was happy enough with my HTML and CSS to take back on the tribute page.

It’s quite ‘basic’ as I was going for something a bit more clean cut, but does hit the marks required - I plan to go a bit more in depth/add some more complicated features when it comes to the portfolio page:

https://codepen.io/Jargallagher/full/ZEzpMyY

Any feedback would be appreciated please!

Hi @JarrettGallagher, welcome back. Your page looks good but there are a couple of things you may want to revisit;

  • keep the test script when forking the pen (<script src="https://cdn.freecodecamp.org/testable-projects-fcc/v1/bundle.js"></script>). Your page passes 9/10 user stories.
  • codepen provides validators for HTML, CSS and JS. Click on the down arrow in the upper right of each section and then click on the respective ‘Analyze’ link.
    • There are issues in HTML you should clean up
  • Don’t use the <br> element to force paragraph breaks. Use the paragraph tags to make each of the paragraphs.
  • review the lesson about giving meaningful text to links
  • make your page responsive. Certain elements fall apart on small screens.