Hello again, everyone!
I just finished my portfolio page and I would like to get some feedback on it. I know it looks very simple, and I would like to improve it.
Criticisms and ideas are welcome.
Hello again, everyone!
I just finished my portfolio page and I would like to get some feedback on it. I know it looks very simple, and I would like to improve it.
Criticisms and ideas are welcome.
Nice clean layout.
What is the soundmanager library you’ve added for? Just out of curiosity.
Your CONTACT ME has some syntax error. An extra <li>
and an incomplete </ul
.
<div class="container">
<a id="contact"><h2>CONTACT ME</h2></a>
<ul>
<li>
<a href="https://www.linkedin.com/in/csnat/" target='_blank'>
<li>
<svg style="width:50px;height:50px" viewBox="0 0 24 24">
<path fill="#000000" d="M21,21H17V14.25C17,13.19 15.81,12.31 14.75,12.31C13.69,12.31 13,13.19 13,14.25V21H9V9H13V11C13.66,9.93 15.36,9.24 16.5,9.24C19,9.24 21,11.28 21,13.75V21M7,21H3V9H7V21M5,3A2,2 0 0,1 7,5A2,2 0 0,1 5,7A2,2 0 0,1 3,5A2,2 0 0,1 5,3Z" />
</svg>
</a>
</li>
<li>
<a href="https://github.com/csnat" target='_black'>
<svg style="width:50px;height:50px" viewBox="0 0 24 24">
<path fill="#000000" d="M5,3H19A2,2 0 0,1 21,5V19A2,2 0 0,1 19,21H14.56C14.24,20.93 14.23,20.32 14.23,20.11L14.24,17.64C14.24,16.8 13.95,16.25 13.63,15.97C15.64,15.75 17.74,15 17.74,11.53C17.74,10.55 17.39,9.74 16.82,9.11C16.91,8.89 17.22,7.97 16.73,6.73C16.73,6.73 15.97,6.5 14.25,7.66C13.53,7.46 12.77,7.36 12,7.35C11.24,7.36 10.46,7.46 9.75,7.66C8.03,6.5 7.27,6.73 7.27,6.73C6.78,7.97 7.09,8.89 7.18,9.11C6.61,9.74 6.26,10.55 6.26,11.53C6.26,15 8.36,15.75 10.36,16C10.1,16.2 9.87,16.6 9.79,17.18C9.27,17.41 7.97,17.81 7.17,16.43C7.17,16.43 6.69,15.57 5.79,15.5C5.79,15.5 4.91,15.5 5.73,16.05C5.73,16.05 6.32,16.33 6.73,17.37C6.73,17.37 7.25,19.12 9.76,18.58L9.77,20.11C9.77,20.32 9.75,20.93 9.43,21H5A2,2 0 0,1 3,19V5A2,2 0 0,1 5,3Z" />
</svg>
</a>
</li>
<li>
<a href="https://codepen.io/csnat/" target='_blank'>
<svg style="width:50px;height:50px" viewBox="0 0 24 24">
<path fill="#000000" d="M15.09,12L12,14.08V14.09L8.91,12L12,9.92V9.92L15.09,12M12,2C11.84,2 11.68,2.06 11.53,2.15L2.5,8.11C2.27,8.22 2.09,8.43 2,8.67V14.92C2,15.33 2,15.33 2.15,15.53L11.53,21.86C11.67,21.96 11.84,22 12,22C12.16,22 12.33,21.95 12.47,21.85L21.85,15.5C22,15.33 22,15.33 22,14.92V8.67C21.91,8.42 21.73,8.22 21.5,8.1L12.47,2.15C12.32,2.05 12.16,2 12,2M16.58,13L19.59,15.04L12.83,19.6V15.53L16.58,13M19.69,8.9L16.58,11L12.83,8.47V4.38L19.69,8.9M20.33,10.47V13.53L18.07,12L20.33,10.47M7.42,13L11.17,15.54V19.6L4.41,15.04L7.42,13M4.31,8.9L11.17,4.39V8.5L7.42,11L4.31,8.9M3.67,10.5L5.93,12L3.67,13.54V10.5Z" />
</svg>
</a>
</li>
</ul
</div>
Nice, Good job
Only problem I have are credits at the bottom of the page “© 2018 Nat”. they are on edge. You can just add
at the end, like this:
<div class="footer">© 2018 Nat <br> <br></div>
EDIT: I added one more br tag
I’m gonna fix the typos. Thanks guys!