Product landing page..-

Code Feedback
1

I have finally completed my product landing pages and will be glad to receive reviews from you.
However I am having troubles adjusting the h1 and h2 elements in the About-us section when resizing the width of the view port. Any suggestions on how I can improve on that are highly welcomed.
Here s the link https://codepen.io/emilynyaruri/pen/ExxGwmq?editors=1100

3 Likes
2

hi again,

im not seeing your “about us” youre mentioned.
my guess is that because they were inside your header element.

3 
      <div class="welcome-img">
        <img src="https://images.pexels.com/photos/609771/pexels-photo-609771.jpeg?auto=compress&cs=tinysrgb&dpr=2&h=650&w=940" alt="company Logo">
      </div>
      <div id="About_Us">
        <h1 id="page-heading">EMMYS FASHION PAGE</h1>
        <h2><em> Best shoes from Africa</em></h2>
      </div>

    </div>```` The one containing the h1 and h2 elements, below the nav and  in the header
4

yes i seen it on larger screen, while not in smaller.

my point is, you may get trouble structuring the html like that.
even if you make the nav element transparent, they are not there.
why not make them outside your header. its easier adjusting them.

5

Thanks a lot for the response. I am implementing that right away

6

Page looks good @emilynyaruri. Something to revisit;

  • Run your HTML code through the W3C validator.
    • Since copy/paste from codepen you can ignore the first warning and first two errors.
    • There are HTML coding errors you should address. Use external styling.
7

Thank you very much @Roma. I will surely revisit that