Product landing project feedback please

Product landing project feedback please
0

I have completed my project. The problem I am having is of home link. When i click the link the home section goes under the nav bar. Please help me out here and any further feedback is appreciated.
https://codepen.io/frankramsey/full/oNjaoJr

For me it also shows that it doesn’t pass all tests. You have not added required id to the video.
I suggest also to use more spacing (margin/padding) , elements are cramped up at the bottom of the page.
I tried and added to home section padding-top 6em and it seems helping. The same is with other sections.

hi @mjjain

why are you repeating @media with same property to each elements you want to alter?

maybe you can do like this :

@media (max-width: 650px) {
       #header { ...
          }
       .nav { ...
          }
       body { ...
          }
   } 

it easier grouping them.

Page looks okay @mjjain. Some things to revisit;

  • Your page passes 15/16 user stories. Click the red button to see which test(s) are failing and text to help you correct the issue.
    • The test script should be included, with all tests passing, when you submit your projects.
  • This is HTML5 so with the iframe element the frameborder attribute is obsolete. Use CSS.

Have you googled this to see what to try?