Record Collection should not be set case give me a error

JavaScript
1

When the test runs these two methods (updateRecords(2548, “artist”, “”) or updateRecords(2548, “tracks”, “”) ), test says that “artist” should not be set. But I believe the code is correct.
when test run


// Setup
var collection = {
    "2548": {
      "album": "Slippery When Wet",
      "artist": "Bon Jovi",
      "tracks": [ 
        "Let It Rock", 
        "You Give Love a Bad Name" 
      ]
    },
    "2468": {
      "album": "1999",
      "artist": "Prince",
      "tracks": [ 
        "1999", 
        "Little Red Corvette" 
      ]
    },
    "1245": {
      "artist": "Robert Palmer",
      "tracks": [ ]
    },
    "5439": {
      "album": "ABBA Gold"
    }
};
// Keep a copy of the collection for tests
var collectionCopy = JSON.parse(JSON.stringify(collection));

// Only change code below this line
function updateRecords(id, prop, value) {
    if(!value){
      return collectionCopy;
    } else if(prop === 'tracks'){
      if(collection[id][prop]){
        collection[id][prop].push(value);
      }else{
        collection[id][prop] = [value];
      }
    } else {
      collection[id][prop] = value;
    }
  return collection;
}

// Alter values below to test your code
updateRecords(5439, "artist", "ABBA");

Your browser information:

User Agent is: Mozilla/5.0 (Windows NT 10.0; Win64; x64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/68.0.3440.106 Safari/537.36.

Link to the challenge:
https://learn.freecodecamp.org/javascript-algorithms-and-data-structures/basic-javascript/record-collection/

2

Take a look at the last part of the challenge:

If value is empty (“”), delete the given prop property from the album.

I don’t think your code is accounting for this? It looks like you’re just returning the entire collection.

3

Ups i miss this line. Thanks for helping.

1 Like
4

No worries friend :smiley: