Simons game feedback/review

Code Feedback
1

Hi guys/girls,
I just finished my last front-end project Simons game, please review and give me a feedback.

https://codepen.io/gmdivani/full/aLwrwW/

thanks a lot for your time!

3

Love the work you did on your simon game. It looks great.

A few suggestions would be:

  • prevent the text on the device to be selected via css, currently if you click it selects parts of the text inside the interface get selected
  • the negative feedback sound when doing something wrong feels too long, about 3 times as long as it feels right.
  • there are a lot of variables declared in the game, maybe try to group them so instead of e.g
var bluebox = true
var redbox = false

do

var config = {}
config.bluebox = true
config.redbox = false

it is one step further up the organisation ladder as far as variable handling is concerned.

Keep up the great work!

1 Like
4

thanks for advice I will change it and sorry for late replay just noticed your comment :slight_smile:

5

Thanks for your feedback. I agree error sound is too long, I was just to lazy to find proper one. I did’t actually knew I can disable select so its a great advice and even greater advice is grouping all those properties under one variable never thought of that possibility but from now on I will be using it a lot.