Taz Tribute Page

Code Feedback
1

I had to reread just about everything. Getting old I guess.
Have a look for fun

2

Hi @CoMIYC69,

html inspector:

  • ‘;’ is not a valid attribute of the h1 element:
 <h1 style="color:red" ;>Looney
----
  • Is better not use the style attribute:
 <h1 style="color:red" ;>Looney

Because, you have multiple styles sources (That’s make the page more difficult to review.):

  • The CSS tab
  • Every element on the html with the style attribute

MDN documentation:
style - HTML: HyperText Markup Language | MDN

The style global attribute contains CSS styling declarations to be applied to the element. Note that it is recommended for styles to be defined in a separate file or files. This attribute and the <style> element have mainly the purpose of allowing for quick styling, for example for testing purposes.

---
  • The <center> element is obsolete and should not be used.
 <center>
    <h1 style="color:red" ;>Looney Tunes The Tasmanian Devil</h1></center>;
  <br>
  <br>
  <center>

MDN documentation:
<center>: The Centered Text element - HTML: HyperText Markup Language | MDN

Deprecated
This his feature has been removed from the Web standards. Though some browsers may still support it, it is in the process of being dropped.Do not use it in old or new projects. Pages or Web apps using it may break at any time.

----
  • Target blank vulnerability
<a href="https://en.wikipedia.org/wiki/Taz" target="_blank"> Wikipedia</a>

MDN documentation:

<a>: The Anchor element - HTML: HyperText Markup Language | MDN

Note: When using target, consider adding rel=“noopener noreferrer”
to avoid exploitation of the window.opener API.

About rel=noopener

TL;DR If window.opener is set, a page can trigger a navigation in the opener regardless of security origin.

Target="_blank" - the most underestimated vulnerability ever

People using target=‘_blank’ links usually have no idea about this curious fact:
The page we’re linking to gains partial access to the linking page via the window.opener object.
The newly opened tab can, say, change the window.opener.location to some phishing page. Or execute some JavaScript on the opener-page on your behalf… Users trust the page that is already opened, they won’t get suspicious.

How to fix
Add this to your outgoing links.

rel="noopener"

Update: FF does not support “noopener” so add this.

rel="noopener noreferrer"

Remember, that every time you open a new window via window.open(); you’re also “vulnerable” to this, so always reset the “opener” property

var newWnd = window.open();
newWnd.opener = null;

Cheers and happy coding :slight_smile:

3

Thanks
I made the changes except for the

var newWnd = window.open();
newWnd.opener = null;

Not sure where to put it

4

You are welcome :smiley: .

I think it’s okay not to add it to this project.

Cheers and happy coding :slightly_smiling_face: