Technical Page Project

Technical Page Project
0

#1

Hey everyone,

Just finished up with the Technical Page Project - had a couple of issues with the side nav bar, and the main document bleeding under the side bar.

Thank you @Ibnalhaytham & @RandellDawson for the help!

Please take a look and project and let me know what you think. I used the sample site and gave it my own styling - really tried to not copy from the sample.

Is the code readable / clean?
Responsive?


#2

Looks good.

  1. You may want to move the overflow from the side-bar to the UL

  2. The default margin on the body is causing some overflow, zero it out.

  3. Remove the negative margin-left on .main-doc at the 400px break point.

  4. Give the content blocks some left/right padding.

About the formatting:

Overall I would say it looks pretty good, there is a bit of an issue with the indentation of the HTML at the end, I can’t tell what the two last closing divs par up with, I think there may be one closing div too many. But it can be really hard to tell on CodePen.

As for the CSS again it’s pretty good. If I am going to nitpick I would like to see the spacing of the selectors and the starting curly brackets be the same in the media queries as outside (i.e. one space after the opening curly bracket).