Tribuite Page Review

Tribuite Page Review
0

#1

Finally completed my Tribute Page for FCC. If possible, please leave a comment with your feedback, all feedback is encouraged. I had trouble with image thumbnails and I feel like my code format is messy. Please let me know if I took the right approach and also any advice is appreciated.

Click here for link.


#2

Hi @Victorp5,

HTML validator:

  • Stray end tag:
<div>
    <!--Header Image-->
      <img class="img-responsive smaller-border align-center" src="http://www.ehowzit.co.za/wp-content/forum/uploads/2015/01/trevor-noah1-395x227.jpg" alt="Trevor Noah with a surprised expression">
</h3>   <-- here (there is no open tag)

</div>

  • Not standard element (</br> ) [the element is like this <br> no " / " ]
blockquote cite="http://www.youlaughbutitstrue.com/"><em>"In life you always choose to see things in a good or bad way, it is how you choose to perceive it. You can choose to perceive things in a positive way, even if they are negative, it just depends on how you look at it."
<strong>
<br>-   <-- good
Trevor Noah</br> <-- here
</strong>

MDN documentation:
https://developer.mozilla.org/en-US/docs/Web/HTML/Element/br


  • A bug :bug: the unclosed <h3> element is afecting the rest of the code (multiple errors):
    </em></blockquote>
<h3 class="slots">
<div class="row">
  <div class="image1 col-xs-6">

MDN documentation:
https://developer.mozilla.org/en-US/docs/Web/HTML/Element/Heading_Elements

A heading element briefly describes the topic of the section it introduces.

  • The same with this <h5>:
<h5 class="slots">
<div class="row">
  <div class="col-xs-6">
  <dl class="text-color-center">
  <dt><strong>Stand Up Comedy</strong></dt> <dd> 
...
  • And this <h5>
<h5 class="slots">
  <div class="row">
    <div class="image3 col-xs-6">

Cheers and happy coding :slight_smile: