Tribute Page | Any kind of input is appreciated!

Tribute Page | Any kind of input is appreciated!
0

#1

Hello all,

I’m looking for any feedback/criticism/suggestion/etc on my tribute page.

  1. Could not tackle how to lineup the lists perfectly
  2. Could not make it responsive
  3. design isn’t that pretty (color, text, etc)

those are some of the things I felt after making this page, and will improve them.

Thanks!!


#2

Hi @danielbyun,
Is better not use the style attribute:

<div class="box" style="background-color:#FFEEEB; color:black; padding:5px; width:100%;">

Because, you have multiple styles sources (That’s make the page more difficult to review.):

  • The CSS tab
  • Every element on the html with the style attribute
  • The <style></style> element

HTML inspector:

  • The center element is deprecated
 <center>
<img class="larger-image thin-silver-border" src="http://media.uaudio.com/blog/2010/05/artist_gear.jpg" alt="hans zimmer" border="6">
</center>

MDN documentation:
https://developer.mozilla.org/en-US/docs/Web/HTML/Element/center

Deprecated
This his feature has been removed from the Web standards. Though some browsers may still support it, it is in the process of being dropped.Do not use it in old or new projects. Pages or Web apps using it may break at any time.


  • An error: (the <ui> element is not valid, the problem is the “i” )
<ui style="list-style-type:disc" class="text-center">
  <li> <strong> 1957: </strong> Hans Zimmer was born on September 12th, in Frankfurt am Main, West Germany </li>

MDN documentation:
https://developer.mozilla.org/en-US/docs/Web/HTML/Element/ul

  • The <font> element is obsolete
<font color="red"> Notice the difference between the original score and a random song for the same scene:</br></br></font>

MDN documentation:

https://developer.mozilla.org/en-US/docs/Web/HTML/Element/font

Obsolete
This feature is obsolete. Although it may still work in some browsers, its use is discouraged since it could be removed at any time. Try to avoid using it.

Cheers and happy coding :slight_smile:


#3

@erretres,

Thank you for your input!

  1. yea i think i went overboard on the style attribute by including in three places, i’m guessing the best bet would be having it on CSS?
  2. argh typos!
  3. I have not noticed those were deprecated elements, (thought those were acceptable after learning them during the lessons … but should pay more attention to CSS haha)

Thank you so much once again!


#4

You’re welcome :smile:

yeah, is easier to review a page with an external css file (you can use a CSSlinter, open a second window and see the rules, know when an element has a rule etc). In codepen is the CSS tab :thumbsup: .

Cheers and happy coding :slight_smile: