Tribute Page - Brian Dawkins

Tribute Page - Brian Dawkins
0

#1

Hey guys,

I just finished up my Tribute Page. I kept it pretty simple, so any feedback to help the page or my code look better is welcome.

Thanks.


#2

Hi @dmurphy5 ,

HTML

  • Do not use lower levels to decrease heading font size
<h1>Brian Dawkins</h1>
      <h4><em>Philadelphia Eagles Legend</em></h4>

MDN documentation:
https://developer.mozilla.org/en-US/docs/Web/HTML/Element/Heading_Elements

**Do not use lower levels to decrease heading font size: use the CSS font-size property instead.**Avoid skipping heading levels: always start from <h1>, next use <h2> and so on.

http://w3c.github.io/html/sections.html#the-h1-h2-h3-h4-h5-and-h6-elements

h2–h6 elements must not be used to markup subheadings, subtitles, alternative titles and taglines unless intended to be the heading for a new section or subsection. Instead use the markup patterns in the §4.13 Common idioms without dedicated elements section of the specification.

Common Idioms
https://www.w3.org/TR/html5/common-idioms.html

-Do not use <br> to increase a gap:

  <h4><em>Philadelphia Eagles Legend</em></h4>
    </div>
    <br>
    <br>

MDN documentation:
https://developer.mozilla.org/en-US/docs/Web/HTML/Element/br

Do not use <br> to increase the gap between lines of text; use the CSS margin property or the <p> element.

Cheers and happy coding :slight_smile: