Tribute Page - Edward Snowden - Looking for feedback on code structure!

Tribute Page - Edward Snowden - Looking for feedback on code structure!
0

#1

Hi all,
Just finished my tribute page on Mr Snowden. This is literally the first page I code so I’m mainly lookking for feedback on the structure of html and css. Like tips on how to better organize and how to better integrat css…

Thanks all!


#2
  1. Inline styles are evil. Move all styles from inside the tags to the CSS portion of CodePen.
  2. The ‘align’ attribute shouldn’t be used. Instead, use the css rule text-align
  3. Instead of using <br> to create space, try adding margin-top and margin-bottom to the elements you want to keep separated.

Those fixes would be a great improvement, but you’re already off to a good start!


#3

From design point of view I would put the two buttons in the same single row and make them not so brrrrrrrrrriiiiiiiiiiiiiiiiiiight :wink:


#4

Thanks guys! Sorry for the late reply.