Tribute page feedback, First FCC project

Tribute page feedback, First FCC project
0
#1

Hey, I just completed my first FCC project, would love any feedback or improvements. https://codepen.io/abubakar-sadeeq-bilyamin/pen/zQqQzj. I used the examples template and used it css too as reference.

#2

very nice colour coordination,
I feel that the text could have been made more readable by using different fonts to break the text up a bit and make it stand out.

1 Like
#3

Hi @thetrueseeker, nice layout.

Codepen supplies you with validators for HTML, CSS and JS. Click on the arrow in the upper right and then click on the respective ‘Analyze’ link.
In your HTML, three of the error can be corrected by adding an equal sign after alt
In CSS you’ve just used an incorrect word.
Side note, you don’t need to use paragraph tags within blockquote tags.

1 Like
#4

I like the colors, and the subject. Very visually appealing. A small correction for accessibility: your image is missing an equal sign (=) after it’s “alt” attribute. And also, I know it’s no biggie, but the link for the wikipedia page is missing. Of course it’s not needed for the purposes of practicing. Nice work =)

2 Likes
#5

lovely work, i particularly love the responsiveness of the page @thetrueseeker , i’m in tune with @afminick 's comments on the small correction for accessibility . I also find the background color quite interesting too, although i think a little bit of color contrast would give the text more visibility. Good job on your first project Sadeeq.

1 Like
#6

Thank you very much, I have fixed the errors.

#7

Thank yo so much, I don’t know how to work with colors, I had to keep experimenting to find the match, if you have any tips it’d be nice hear them

#8

I added the wikipedia page, its better to get used to good practices now than having to painfully learn them later

#9

@thetrueseeker your page looks really well made. I cannot think of much you need to do to improve it.
How about setting text-align: justify on your paragraphs?