Tribute Page, Feedback Please

Code Feedback
1

Hi I just finished my tribute page and was wonder if I could get some feedback.

Tribute Page

Thank you in advance.

2

Hi @chups2themax,

HTML:

  • You can use an h1 element(more descriptive):
<div class="col-xs-12" id="page-title">
 Leonhard Euler
</div>

MDN documentation:

<h1>–<h6>: The HTML Section Heading elements - HTML: HyperText Markup Language | MDN

The HTML <h1>–<h6> elements represent six levels of section headings. <h1> is the highest section level and <h6> is the lowest.

  • Avoid skipping heading levels, always start from <h1> :
<div class="col-md-6 col-sm-6 col-xs-12">
 <h4 class="section-title">Leonhard Euler</h4>
<ul>

MDN documentation:
<h1>–<h6>: The HTML Section Heading elements - HTML: HyperText Markup Language | MDN

Do not use lower levels to decrease heading font size: use the CSS font-size property instead.Avoid skipping heading levels: always start from <h1>, next use <h2> and so on.

  • Do not use <br> to increase a gap:
<!-- Inserted page breaks and added github link to profile -->
<br>
<br>
<footer>

MDN documentation:
<br>: The Line Break element - HTML: HyperText Markup Language | MDN

The HTML <br> element produces a line break in text (carriage-return). It is useful for writing a poem or an address, where the division of lines is significant.

Cheers and happy coding :slight_smile:

1 Like