Tribute Page - Feedback please

Tribute Page - Feedback please
0

#1

Would love some feedback here… this is rescue squirrel my kids took care of… simple and easy.


#2

Hi Mackage666,

This code is more readable in an external css (in codepen the css tab)


<style>
  h1 {    
    font-family: Oswald;
    font-size: 120px;
      }
  
  h2 {
    font-family: Architects Daughter;
    font-size: 40px;
      }
    
    p {
      font-family:  Covered By Your Grace;
      font-size: 70px;
      }
     
  .list {
    font-family: Covered By Your Grace;
    font-size: 50px;
    align: center;
  }
  
  .smaller-image {
    width: 800px;
    align: center;
   }
  
  .thick-green-border {
    border-color: white;
    border-width: 30px;
    border-style: solid;
    border-radius: 60%;
  }
}
</style>

html inspector:

- The 'alt' attribute is required for `````` elements.
- 'class-"list' is not a valid attribute of the `````` element. - 'text-center"' is not a valid attribute of the `````` element. ```html ```
  • A lost </a> element:
<div class="container-fluid text-center"> 
  <h1 class="text-primary">Jumpy The Squirrel </h1>
  <center><img src="http://www.livescience.com/images/i/000/025/221/original/squirrel.jpg?interpolation=lanczos-none&downsize=696:*" class="smaller-image thick-green-border">
</a>  <-- here

Its looks great, I really like the font and the focus on content.

Cheers and happy coding :slight_smile:


#3

Thanks for the feedback! Definitely need to work on my readability. So move the entire STYLE section to the CSS box?


#4

yeah, without the <style> tag only the rules :thumbsup: .

Cheers and happy coding :slight_smile: