Tribute Page for Review - Thanks!

Tribute Page for Review - Thanks!
0

#1

Hi - i recently finished my first Project and would like to get some Feedback at it.
It is pretty basic, but i would still love to know, if there is anything i can do better.

Thanks!


#2

Hello @meli,

  • Do not use lower levels to decrease heading font size:
<div class="col-sm-12">
      <h3 class="text-center">SARA FABER</h3>
      <h4 class="text-center">Visual Development Artist</h4>

MDN documentation:
https://developer.mozilla.org/en-US/docs/Web/HTML/Element/Heading_Elements

Do not use lower levels to decrease heading font size: use the CSS font-size property instead.Avoid skipping heading levels: always start from <h1>, next use <h2> and so on.

http://w3c.github.io/html/sections.html#the-h1-h2-h3-h4-h5-and-h6-elements

h2–h6 elements must not be used to markup subheadings, subtitles, alternative titles and taglines unless intended to be the heading for a new section or subsection. Instead use the markup patterns in the §4.13 Common idioms without dedicated elements section of the specification.

Common Idioms
https://www.w3.org/TR/html5/common-idioms-without-dedicated-elements.html#common-idioms-without-dedicated-elements


  • Target blank vulnerability
<a href="https://www.artstation.com/sarafaber" target="_blank"> Artstation </a>.

MDN documentation:

https://developer.mozilla.org/en-US/docs/Web/HTML/Element/a

Note: When using target, consider adding rel="noopener noreferrer"
to avoid exploitation of the window.opener API.

https://mathiasbynens.github.io/rel-noopener/

TL;DR If window.opener is set, a page can trigger a navigation in the opener regardless of security origin.

https://www.jitbit.com/alexblog/256-targetblank---the-most-underestimated-vulnerability-ever/

People using target=’_blank’ links usually have no idea about this curious fact:
The page we’re linking to gains partial access to the linking page via the window.opener object.
The newly opened tab can, say, change the window.opener.location to some phishing page. Or execute some JavaScript on the opener-page on your behalf… Users trust the page that is already opened, they won’t get suspicious.

How to fix
Add this to your outgoing links.

rel="noopener"

Update: FF does not support “noopener” so add this.

rel="noopener noreferrer"

Remember, that every time you open a new window via window.open(); you’re also “vulnerable” to this, so always reset the “opener” property

var newWnd = window.open();
newWnd.opener = null;


Cheers and happy coding :slight_smile:


#3

Thank you for the detailed explanation and sources, @erretres ! Really helpful.
Read all attached sources and improved the pen :slight_smile:


#4

You’re welcome :smiley:

Cheers and happy coding :slight_smile:


#5

Style wise you could experiment with shadowboxes.

You could also create a title class and use some transform. I’m not a fan of having to all caps things.

https://www.w3schools.com/cssref/pr_text_text-transform.asp