My first indie project.
It makes me so proud
My first indie project.
It makes me so proud
Looks really good! No errors in your html or css, and its responsive. Heads up, I noticed that you didnt pass one test case for the welcome-section, so fix that to pass all the tests. But other than thatā¦canāt say anything stands out as an issue.
You should be proudā¦great job
Thanks Candice
Thatās weird, it shows me 10/10.
It would, of course, be helpful if I selected the correct test suite from the drop down Yes indeed, you got a 10/10ā¦ my mistake!!!
Haha, no problem my friend.
Thanks for your time.
Nice work! Really clean, and nice choice of colours.
I suggest trying to make the top part less empty. The image is mostly blank background, so I feel you donāt have to show its entire width. Maybe itās just me.
Also, the space under the image is a bit to big, so that also contributes to the empty feel.
With regards to accessibility, the alt attribute is usually used to give information about the image, so I would change it from āalt=āIMAGEāā to something more informative. Imagine that someone who is visually impaired is going through your page - how would you describe the image?
There are some things you could improve in the mobile display as well:
Thank you very much zurda!
about the image alt, yea I forgot to change it (just put it there for the prototype) so thanks for noticing.
Iāll work on it some more with your tips. This is the learning curve
p.s
for the mobile display should I use media query?
Sure thing Thereās no rush, and itās definitely a curve (Iām currently improving my survey challenge, so Iām right there with you in the process).
These are improvements you can do while youāre learning. For me, Iām working on the project while completing more items in the curriculum - this way, whenever Iām tired of one thing, I can switch to the other.
Yes, you can use media query to set different CSS for the mobile layout. For example, you set the #main
width to 90% in regular layout, and the #tribute-info
max-width to 65% -> you might want to make these larger in mobile. You should try changing these values in mobile, until you feel youāre using as much as possible of the screen (while keeping a clean and not too ābusyā look to the page). Also, maybe there are some margins / paddings you could change to 0
in mobile display.
And again, this is a learning process, so it doesnāt have to be perfect, but itās worthwhile changing those values until you find a mobile friendly display. I hope this makes sense.
Keep up the good work, and we canāt wait to see your next project Happy coding!
Thanks Michal, I appreciate all the tips you gave me.
Wish you the best and iād be glad to see your future work
×Ŗ×××!
I like your tribute page but I must admit, it bothers me a little that you didnāt go for an original gameboy. Thatās like making a nokia tribute page and not using the nokia 3310 on your frontpage. To assist you I have added an original gameboy below
XD thanks a lot tomvbe.
iāll add it asap.