Tribute project(please give your feedback on the shortcomings.thank you.)

Tribute project(please give your feedback on the shortcomings.thank you.)
0

#1

#2

Hi @Ace-ezer,

CSS inspector:

  • Unknown property ‘font-decoration’
h4 { font-size: 20px;
     font-family: helvetica;
      font-decoration: bold;}
  • You can use font-weight:

https://developer.mozilla.org/en-US/docs/Web/CSS/font-weight


  • The <center> element is obsolete and should not be used.
<footer><center>Written and coded by Arpit Yadav</center></footer>

MDN documentation:
https://developer.mozilla.org/en-US/docs/Web/HTML/Element/center

Deprecated
This his feature has been removed from the Web standards. Though some browsers may still support it, it is in the process of being dropped.Do not use it in old or new projects. Pages or Web apps using it may break at any time.


Is better not use the style attribute:

div style="background-color: gainsboro" class="container-fluid text-center" id="tribute1">

Because, you have multiple styles sources (That’s make the page more difficult to review.):

  • The CSS tab
  • Every element on the html with the style attribute

MDN documentation:
https://developer.mozilla.org/en-US/docs/Web/HTML/Global_attributes/style

The style global attribute contains CSS styling declarations to be applied to the element. Note that it is recommended for styles to be defined in a separate file or files. This attribute and the <style> element have mainly the purpose of allowing for quick styling, for example for testing purposes.


Cheers and happy coding :slight_smile:


#3

thank you! for your review. I’ll keep those perks in mind next time.