Weather App Feedback 2018

Weather App Feedback 2018
0

#1

Hi everybody ,

I need feedback for my Weather App to improve my skills.

https://codepen.io/Nabii/pen/GQKRpd

Thanks for your help :wink:


#2

Why did you add https://cdnjs.cloudflare.com/ajax/libs/twitter-bootstrap/4.0.0-beta/js/bootstrap.min.js to your Codepen settings for the JS module, but are not actually using any Bootstrap syntax in your html?

Also, since you added https://cdnjs.cloudflare.com/ajax/libs/jquery/3.2.1/jquery.min.js to your Codepen settings for the JS module, you can delete the following from the html section. You are loading two different versions of the jQuery library when you only need one.

Loading extra libraries which you do not need or use slows down your page loading time in general.

One suggestion for smaller screen devices is to replace:

html {
	background-size: cover;
	background-repeat: no-repeat;
}

with the following:

html {
	background-size: cover;
	background-position: center center;
	background-repeat:  no-repeat;
	background-attachment: fixed;
}

The background-attachment: fixed; in particular will force the background to use the full height of the page also. The background-position: center center; sets the focus of the image to the center (horizontally and vertically) when the image grows in height and width.


#3

Hello randelldawson,

Thanks for your observation.

I was using Bootstrap at the beginning then I change my mind and I forgot to delete https://cdnjs.cloudflare.com/ajax/libs/twitter-bootstrap/4.0.0-beta/js/bootstrap.min.js to my Codepen setting.

Moreover, thanks for the advice and explanation concerning :

background-position: center center;
background-attachment: fixed;