What do you think about my Random Quote Machine?

Code Feedback
1

My project:

Random Quote Machine

I used Bulma and javascript without Jquery.

What do you think? i need you feedback,

Thanks!!

2

I must say I love the background and font color combination with the font family you’ve used! The button though is kind of off compared to the rest of the page styling and in the wrong position in my opinion. Personally I’d center it underneath the quote. Additionally that vertical scrollbar kind of bothers me, it shouldn’t be there.

Other than the styling comments, you have an error in your JS.
var r = Math.floor(Math.random() * quotes.length + 1);
should be
var r = Math.floor(Math.random() * quotes.length);
because your quotes’ array first index is 0 and the last one is quotes.length - 1. By adding + 1 you skip the first element and also might get an element that doesn’t exist (quotes[quotes.length])

If you need help with anything of the above get back to me!

3

Thank you sir,

It was some mistake when i wrote it in the javascript lol.

Now i changed a little the layout and tried some fadein and fadeout.

Random Quote Machine by Ronaldo

4

It’s okay you’ll do the simplest mistakes a billion times no matter how much experience you get :wink: I like the layout much better now! Let’s see what others think!

1 Like